-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add localusers contacts to core #8951
Conversation
🚀 Test Passed. 🚀 |
@@ -0,0 +1,169 @@ | |||
<?php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class/file is needed to let the LocalUsers
backend work. Is it okay to move this to core?
Should I remove these classes from the Contacts app? (If so maybe move them to \OCP\
?)
🎆 it's working :) TODO's
16/06
|
🚀 Test Passed. 🚀 |
🚀 Test Passed. 🚀 |
💣 Test Failed. 💣 |
🚀 Test Passed. 🚀 |
🚀 Test Passed. 🚀 |
Avatars are now automatically uploaded to the contacts, even when they are changed. |
🚀 Test Passed. 🚀 |
🚀 Test Passed. 🚀 |
Displaynames are now automatically uploaded to the contacts, even when they are changed. |
🚀 Test Passed. 🚀 |
I think the work here is done. |
💣 Test Failed. 💣 |
@owncloud-bot retest this please |
💣 Test Failed. 💣 |
💣 Test Failed. 💣 |
💣 Test Failed. 💣 |
💣 Test Failed. 💣 |
I'm ready with this and this can be tested, can someone add a @jancborchardt about the implemantation:
This can be reviewed. |
Refs http://stackoverflow.com/questions/16229004/oracle-cannot-insert-a-null-value-to-a-non-primary-key It looks like the query needs to insert |
The inspection completed: 33 new issues, 67 updated code elements |
Now it fails on pgsql:
|
I was wrong with the id. It's trying to insert |
@LEDfan okay - I'm back on this pull request - sorry too much other things going on here so we have still more than 1000 LOC? Still a big bunch - I'll have a closer look ... |
A new inspection was created. |
The inspection completed: 33 new issues, 67 updated code elements |
@DeepDiver1975 I checkout this branch with an oracle DB server. Everything works as expected. |
A new inspection was created. |
@jancborchardt @DeepDiver1975 TODO (for me)
|
A new inspection was created. |
The inspection completed: 47 new issues, 48 updated code elements |
💣 Test Failed. 💣 |
💣 Test Failed. 💣 |
if we walk th path of #9641 this pull request is no longer needed. |
Yeah, that’s what I meant. The core should only expose the local users through some kind of API. It’s up to the apps to implement the API then. |
@jancborchardt yup. |
In this PR the currently implemented Localusers backend for the contacts app will be moved to core.
@DeepDiver1975 is this how I should implement it? The
\OC\Contacts\Backend\LocalUsers
class will be almost the same as\OCA\Contacts\Backend\Localusers
. (which will be removed of course)Some questions:
\OCA\Contacts\Backend\AbstractBackend
class. This should stay the same for the localusers class in core. Should I move theAbstractBackend
class to the public namespace of core, and remove it out of the contacts app?